silence improper_ctypes warning #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
LPardue
previously approved these changes
Nov 7, 2019
This is actually a false positive, as the structs are only exposed to FFI as pointers, so they are effectively opaque from the non-Rust perspective The warning showed up in nightly after the following PR was merged: rust-lang/rust#65134
ghedo
force-pushed
the
no-improper-ctypes
branch
from
aaa4fce
to
39fd099
Compare
|
I've opened an issue discussing this here: rust-lang/rust#66220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a false positive, as the structs are only exposed to
FFI as pointers, so they are effectively opaque from the non-Rust
perspective
The warning showed up in nightly after the following PR was merged:
rust-lang/rust#65134